chore: Add AsyncCloseable interface. #95
Conversation
| * Immediately closes the resource gracefully. | ||
| */ | ||
| default void close() { | ||
| this.closeGracefully().subscribe(); |
There was a problem hiding this comment.
Maybe the default implementation should call block
|
|
||
| /** | ||
| * Begins the process of closing the resource gracefully, if there is one in progress, | ||
| * return the existing one. |
There was a problem hiding this comment.
I don't think that's accurate? We'd need to keep track of closing-in-progress and I am not certain we do that currently.
There was a problem hiding this comment.
So you suggest we drop the :
if there is one in progress, return the existing one.
?
I think we should always return the same instance.
There was a problem hiding this comment.
I checked the code, you are right, not all implementation return the same Mono, will drop this description.
| Mono<Void> closeGracefully(); | ||
|
|
||
| /** | ||
| * Immediately closes the resource gracefully. |
There was a problem hiding this comment.
The graceful close is not immediate, it kicks off asynchronously. In the cases of void return type it is a disconnected chain.
| @@ -52,6 +52,7 @@ public interface McpServerTransportProvider { | |||
| * Immediately closes all the transports with connected clients and releases any | |||
| * associated resources. | |||
| */ | |||
| @Override | |||
|
|
||
| /** | ||
| * Immediately closes the resource gracefully. | ||
| */ |
There was a problem hiding this comment.
An @see #closeGracfully() javadoc entry would be useful.
| Mono<Void> closeGracefully(); | ||
|
|
||
| /** | ||
| * Closes the session and releases any associated resources. | ||
| */ | ||
| @Override |
| @@ -45,6 +45,7 @@ public interface McpTransport { | |||
| * needed. It should handle the graceful shutdown of any active connections. | |||
| * </p> | |||
| */ | |||
| @Override | |||
He-Pin
force-pushed
the
asyncCloseable
branch
2 times, most recently
from
c8a8746 to
66f6e35
Compare
Signed-off-by: He-Pin <[email protected]>
Motivation and Context
Introduce a common interface for autocloseable.
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context